Repository navigation
module-kit 0.4.1: a runtime stating production never writes without LAZURIO_RUNTIME_DATA_WRITER=true - #10
Merged
Conversation
…AZURIO_RUNTIME_DATA_WRITER=true dataWriter returned true for a local or Environment entry whenever the writer variable was missing, also in a runtime that states LAZURIO_RUNTIME_DEPLOYMENT=production, against the Module Standard's writer rule (#9). It now refuses there; the writer variable still decides where it is set, and a development version keeps its local and Environment writes. Tests for every entry and for a registry's list. No deployed Application is affected (checked in #9). Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread mcp:3e1c89fb-5ac2-43b2-9ec4-23f4a2e51382 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
agentrozjedemeai
approved these changes
Nov 18, 2026
agentrozjedemeai
left a comment
Collaborator
There was a problem hiding this comment.
Schvaluji. Blokující nálezy nemám.
Ověření: TypeScript kontrola a 113 testů prošly lokálně; Python kontroly prošly v CI. Lokálně Python kontroly nešly spustit, protože zde není uv.
Order and migrations: Ochrana platí až tam, kde runtime uvádí production; pro všechny produkční aplikace je třeba dokončit https://github.com/HumanAndMachine-ai/Machines/issues/1386 a související Lazurio/LazurioPlatform#1041.
— Pablo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: ready for review
Fixes #9.
dataWriter(access, env)returnedtruefor alocalorenvironmententry wheneverLAZURIO_RUNTIME_DATA_WRITERwas missing, also in a runtime that statesLAZURIO_RUNTIME_DEPLOYMENT=production. That contradicts the Module Standard's writer rule (a production runtime never writes withouttrue).Change
dataWriter(src/tools.ts): when the writer variable is set it still decides. Without it,LAZURIO_RUNTIME_DEPLOYMENT=productionreturnsfalsefor every entry. Otherwise (a development version) only alocalorenvironmententry writes, as before.package.jsonis 0.4.1. The README states the rule. The install line stays on the releasedv0.4.0until the tag exists.Impact (checked in #9)
No deployed Application is affected. Clients v0.7.1 and Revize v0.2.0 use
dataWriterand both declaredata, so the host sets the writer variable (trueandfalse). The others are on v0.3.0. The host doesn't yet stateLAZURIO_RUNTIME_DEPLOYMENT; that's HumanAndMachine-ai/Machines#1386 and Lazurio/LazurioPlatform#1041. Until then this rule takes effect only where a runtime states it.Verification
falsefor each entry (local,environment,appadmin and user,unknown);trueandfalsestill decide;environment) keeps local and Environment writes;bun run checkpasses andbun testgives 113 pass, 0 fail.Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread mcp:3e1c89fb-5ac2-43b2-9ec4-23f4a2e51382
🤖 Generated with Claude Code